Skip to content

Migrate CategoriesFragment to Compose#4440

Merged
frett merged 2 commits into
developfrom
articleRendererComposeTransition
Jun 1, 2026
Merged

Migrate CategoriesFragment to Compose#4440
frett merged 2 commits into
developfrom
articleRendererComposeTransition

Conversation

@frett

@frett frett commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Rewrites CategoriesFragment to use Jetpack Compose (LazyColumn + RenderArticleCategory) in place of DataBinding/RecyclerView
  • Removes CategoriesAdapter and all associated XML layouts/drawables/styles
  • Cleans up unused dependencies (constraintlayout, recyclerview, viewBinding, gtoSupport.picasso, etc.) from article-renderer

Test plan

  • Open the article renderer categories screen and verify categories render correctly
  • Tap a category and verify navigation to the articles list works
  • Verify analytics screen event (SCREEN_CATEGORIES) fires on resume

🤖 Generated with Claude Code

@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.24%. Comparing base (e91de5a) to head (9753065).

Files with missing lines Patch % Lines
...dtools/article/ui/categories/CategoriesFragment.kt 0.00% 26 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4440   +/-   ##
========================================
  Coverage    52.24%   52.24%           
========================================
  Files          457      456    -1     
  Lines        12170    12170           
  Branches      2109     2108    -1     
========================================
  Hits          6358     6358           
  Misses        5192     5192           
  Partials       620      620           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

frett and others added 2 commits May 28, 2026 12:05
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@frett frett force-pushed the articleRendererComposeTransition branch from fb124dc to 9753065 Compare May 28, 2026 18:06
@frett frett requested a review from tjohnson009 May 28, 2026 18:11
@frett

frett commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

@tjohnson009 this is maintenance work of trying to move away from databinding

@frett frett merged commit eeadde5 into develop Jun 1, 2026
13 checks passed
@frett frett deleted the articleRendererComposeTransition branch June 1, 2026 23:49
@tjohnson009

Copy link
Copy Markdown
Contributor

Why do we want to move away from databinding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants